expose close callback

Open Beginner friendly
#613 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
javascript, nodejs
Domain
networking

Research direction

Start in lib/WebSocket.js around the .close(code, data) method at line 100 and the related code near line 121. Trace how the close operation is exposed, then make the callback available there and verify the existing WebSocket tests cover the callback behavior.

Written by the indexing model from the issue text.

Description

You have a .close(code, data) method here:
https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L100

But you don't expose the callback here:
https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L121

Dominant language
JavaScript
Stars
22.8k
Forks
2.6k
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from websockets/ws

All issues in websockets/ws

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.