Auth pending-approval action_token overwritten by reset-password-request

Open
#722 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Domain
authentication, security

Research direction

Start with the Auth fixture's handling of the registration pending and password-renewal action_token flows, then reproduce the sequence described in the issue: request approval, request a password reset, and change the password. Done means password reset cannot bypass pending approval, while legitimate password renewal still works; no specific files or tests are named.

Written by the indexing model from the issue text.

Description

It is very easy to circumvent the admin approval requirement of the Auth fixture. If a user whose account is pending asks for a password reset, the registration pending action token gets replaced with a password renewal token. After user changes the password, he is let in without any admin intervention. Perhaps, tokens should not be replaced but chained in the action_token field?

Dominant language
HTML
Stars
319
Forks
144
Avg merge
6d 20h
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from web2py/py4web

All issues in web2py/py4web

Similar issues

More Security issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.