From one and a half minutes to one hour to send
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 28/100
Research direction
Start with the reported sending loop and the queueNotification() and flush() calls, reproducing the timing difference between web-push-php versions 6 and 8 with 44,000 endpoints. Compare batch behavior and request timing around each flush, then confirm that the sending duration is reduced without changing the notification payload or endpoint handling.
Written by the indexing model from the issue text.
Description
Setup
- Operating System: Linux
- PHP Version: 8.1
- web-push-php Version: 8.0
PHP extensions :
- curl
- gmp
- mbstring
- openssl
browsers:
- Chrome
- Firefox
- Firefox for Mobile
- Opera for Android
- Samsung Internet Browser
- Other
I was using version 6, and 44,000 endpoints were being sent in 1m 40s. After updating to version 8, the time has increased to almost 1 hour, and I don’t know what could be the reason.
This is the portion of sending code
$defaultOptions = [
'TTL' => 300, // defaults (300) to 4 weeks
'urgency' => 'normal', // protocol defaults to "normal"
'topic' => 'new_event', // not defined by default,
'batchSize' => 1000, // defaults to 1000
'verify' => false,
'timeout' => 6, // defaults to 20
'\GuzzleHttp\RequestOptions::ALLOW_REDIRECTS' => false
];
$webPush = new WebPush([], $defaultOptions);
$webPush->setAutomaticPadding(true);
$auth = array(
'VAPID' => array(
'subject' => 'https://www.mydomain.com',
'publicKey' => file_get_contents(__DIR__ . '/../../../../keys/public_key.txt'),
'privateKey' => file_get_contents(__DIR__ . '/../../../../keys/private_key.txt'),
),
);
$webPush = new WebPush($auth);
$i = 0;
$notifications = [];
while ($row_subscription = $result -> fetch_assoc()){
$i ++;
$subscription_id = $row_subscription['subscription_id'];
$payload = [
"title" => $row_notificacion['title'],
"body" => $row_notificacion['body'],
"badge" => $row_notificacion['badge'],
"icon" => $row_notificacion['icon'],
"image" => $row_notificacion['image'],
"url" => $row_notificacion['url'],
"id" => $notification_id,
"sid" => $subscription_id,
"requireInteraction" => true,
"vibrate" => "[300, 100, 400]"
];
$data = json_encode($row_subscription);
$subscription = Subscription::create(json_decode($data, true));
$notifications[] = [
'subscription' => $subscription,
'payload' => json_encode($payload),
];
if ($i % 1000 == 0 || $result->num_rows == $i) {
foreach ($notifications as $notification) {
$webPush->queueNotification($notification['subscription'], $notification['payload']);
}
foreach ($webPush->flush() as $report) {
handleReport();
}
$notifications = [];
}
}
Thank you
- Dominant language
- PHP
- Stars
- 1.9k
- Forks
- 312
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 1
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from web-push-libs/web-push-php
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
web-push-libs/web-push-php#441 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
web-push-libs/web-push-php#430 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
web-push-libs/web-push-php#429 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
web-push-libs/web-push-php#412 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
web-push-libs/web-push-php#411 · 5 comments ·
All issues in web-push-libs/web-push-php
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 2 days
-
[Area] REST API [Type] Documentation Good First Issue
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
WordPress/presence-api#584 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100