web-push-php API signature change
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start by tracing the Subscription::create entry point and how its array arguments are interpreted. Confirm that named publicKey and authToken values work, then define the completed behavior as rejecting positional parameters with an error while preserving the documented named-parameter form.
Written by the indexing model from the issue text.
Description
I lost countless hours trying to make it send the payload.
I used this code Subscription::create([
'endpoint' => $endpoint, $p256dh, $keys_auth, 'contentEncoding' => 'aesgcm',
]),
Notice I used position parameters and it gives no error (except in the case of "endpoint").
Instead, it should be like this:
Subscription::create([
'endpoint' => $endpoint, 'publicKey' => $p256dh, 'authToken' => $keys_auth, 'contentEncoding' => 'aesgcm',
]),
I think it should raise an error if any of the parameters is provided without a name.
- Dominant language
- PHP
- Stars
- 1.9k
- Forks
- 312
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 1
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from web-push-libs/web-push-php
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
web-push-libs/web-push-php#441 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
web-push-libs/web-push-php#430 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
web-push-libs/web-push-php#429 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
web-push-libs/web-push-php#412 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
web-push-libs/web-push-php#411 · 5 comments ·
All issues in web-push-libs/web-push-php
Similar issues
-
product / auth product / databases product / sites product / vcs
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
backend enhancement good first issue php
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
`Batch_Error_NotifierTest::test_does_not_send_duplicate_to_same_email` — errors on WordPress nightlyOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
google/site-kit-wp#13702 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
doctrine/collections#554 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Automattic/static-site-importer#1859 ·
Maintainers usually reply within 1 day