Add strong name to assemby

Open
#30 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
build-system

Research direction

The issue names no files or tests; start by locating the library project configuration and its current target frameworks. Check how strong naming is configured and verify the resulting package supports netstandard1.1, netstandard2.0, and net46 without the application-only targets.

Written by the indexing model from the issue text.

Description

It is impossible to use this library in strong named applications, because it does not have strong name.

Also, there are no sense to use netcoreapp1.0;netcoreapp1.1;netcoreapp2.0 as target frameworks, this frameworks are actual for applications not library. Better to use netstandard2.0 framework for dotnetcore and net46 for normal windows framework (without this target 'big' framework will use netstandard1.1 and lot of shims). So, all set of frameworks should be similar to this: netstandard1.1;netstandard2.0;net46

Dominant language
C#
Stars
453
Forks
114
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from web-push-libs/web-push-csharp

All issues in web-push-libs/web-push-csharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.