web-platform-tests/wpt

WebSocketDaemon attempted spawn even when ws_doc_root is null

Open

#8,675 opened on Dec 13, 2017

View on GitHub
 (7 comments) (0 reactions) (0 assignees)HTML (4,581 stars) (2,898 forks)batch import
good first issueinfrapriority:backlog

Description

If ws_doc_root is null (default in config.default.json), server.py still attempts to spawn WebSocketDaemons, which then fail due to lack of config.

I'm pretty new to wpt so not sure if desired behavior in this case is to

a) Require that ws_doc_root be set b) If ws_doc_root is not set, skip spawning WebSocketDaemon c) Make WebSocketDaemon handle null and default config better

For now, I assuming b) but defer to experts in terms of how this should be handled.

Contributor guide

Tech stack
python
Domain
backendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Python basicswpt configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the discussion in the issue comments (7 comments) to see if maintainers have indicated a preference among options (a), (b), or (c). If no clear direction, implement option (b) as suggested by the author: skip spawning WebSocketDaemon when ws doc root is null. Modify the relevant code in server.py to check for null before spawning. Update config.default.json if necessary to set a default value or document the behavior.