web-platform-tests/wpt

Creation of a handler which doesn't set a string as response content hangs the server

Open

#8,368 opened on Nov 20, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (2,898 forks)batch import
good first issueinfrapriority:backlogwptserve

Repository metrics

Stars
 (4,581 stars)
PR merge metrics
 (Avg merge 5d 23h) (682 merged PRs in 30d)

Description

Originally posted as https://github.com/w3c/wptserve/issues/105 by @whimboo on 28 Oct 2016, 12:22 UTC:

The following handler will cause the server to hang while delivering the page content:

  def handler(request, response):
        response.content = 1
        return ()

This happens because a non-string value gets set as the content.

Contributor guide

Research direction
Investigate the wptserve handler module (likely in tools/wptserve/). The issue occurs when response.content is set to a non string value (e.g., integer). Look at how the server sends content, possibly in the Response class's write or send methods. Ensure that all content values are converted to string before transmission. The original wptserve issue #105 may have additional context.
Tech stack
python
Domain
backendtesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic understanding of PythonFamiliarity with wptserve handler
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60