Give a clearer error when Safari Technology Preview isn't installed
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- cli, testing-qa
Research direction
Start in tools/wpt/run.py, especially setup_kwargs where the WptrunError is raised, and trace the Safari runner setup invoked by ./wpt run safari foo. Check how the safaridriver path is determined. Done means a missing Safari Technology Preview installation produces a clear error that identifies the expected application path.
Written by the indexing model from the issue text.
Description
By default you get something like:
gsnedders@gsnedders-margot web-platform-tests % ./wpt run safari foo
/Volumes/gsnedders/projects/wpt/web-platform-tests/_venv3/lib/python3.9/site-packages/urllib3/__init__.py:35: NotOpenSSLWarning: urllib3 v2 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 3.3.6'. See: https://github.com/urllib3/urllib3/issues/3020
warnings.warn(
Traceback (most recent call last):
File "/Volumes/gsnedders/projects/wpt/web-platform-tests/./wpt", line 10, in <module>
wpt.main()
File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/wpt.py", line 233, in main
rv = script(*args, **kwargs)
File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 994, in run
setup_cls, wptrunner_kwargs = setup_wptrunner(venv, **kwargs)
File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 966, in setup_wptrunner
setup_cls.setup(kwargs)
File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 248, in setup
self.setup_kwargs(kwargs)
File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 740, in setup_kwargs
raise WptrunError("Unable to locate safaridriver binary")
tools.wpt.run.WptrunError: Unable to locate safaridriver binary
This is a pretty bad user experience; it's not at all obvious what it was looking for (/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver).
- Dominant language
- HTML
- Stars
- 6.2k
- Forks
- 3.9k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 586
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from web-platform-tests/wpt
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
web-platform-tests/wpt#62635 ·
-
type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
web-platform-tests/wpt#62623 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
web-platform-tests/wpt#62525 ·
-
wdspec: bidi_session fixture swallows setup failures, reporting them as bare StopAsyncIteration Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
web-platform-tests/wpt#62500 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
web-platform-tests/wpt#62415 · 2 comments ·
All issues in web-platform-tests/wpt
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
from:qa priority:P2 reliability tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
spec-kitty/spec-kitty#4874 ·
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/fulltextsearch#1011 ·
-
automation code-quality cookie deep-report documentation improvement quick-win task-mining
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100