web-platform-tests/wpt

Expand event-handler-attributes-body-window.html

Open

#2314 opened on Nov 10, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (4,581 stars) (2,898 forks)batch import
good first issuehtmltype:missing-coverage

Description

The test at html/webappapis/scripting/events/event-handler-attributes-body-window.html could be expanded. For example, currently it tests

    document.body['on' + handler] = f;
    assert_equals(window['on' + handler], f);

while it could also test the opposite direction:

    window['on' + handler] = f;
    assert_equals(document.body['on' + handler], f);

Also, it would be useful to test with:

  • a frameset as the body
  • a frameset or body element that's not in a document
  • a frameset or body element that's not the body element (for example, with multiple body elements in the DOM).

Contributor guide

Tech stack
htmljavascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HTML DOMevent handlers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requests expanding the test file at html/webappapis/scripting/events/event handler attributes body window.html. Follow the existing pattern to add tests for setting window['on' + handler] and checking document.body, and for frameset and disconnected elements. See the existing test for reference.