web-platform-tests/wpt

selectionchange testing TODOs

Open

#11,493 opened on Jun 13, 2018

View on GitHub
 (8 comments) (0 reactions) (2 assignees)HTML (4,581 stars) (2,898 forks)batch import
good first issueselectiontype:missing-coverage

Description

Over in PR #11491 I introduced a preliminary test for the selectionchange event.

Here is an initial pass at a TODO for more tests we should write for selectionchange:

  • test for invoking selectionchange without changing the selection
  • test that selection change does not fire in a document without a browsing context (i.e. document.implementation.createHTMLDocument)
  • test which document selectionchange fires when it is bound to in an iframe

While writing this initial coverage I encountered the following behavior which warrants further exploration in future tests/bugs/implementation patches. This area has a lot of compat issues to track down, so I think there may be a bunch of 'good first issues here':

  • When selectAllChildren runs, Firefox synchronously fires selectionchange, while Chrome appears to que a task.
  • selectAllChildren works on textareas in chrome and not firefox, while accessing textContent works in firefox but not chrome.
  • textarea innerText and textContent behave differently in Chrome and FF

Contributor guide

Tech stack
javascripthtml
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of selection APIbasic JavaScriptbrowser compatibility concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Start by reviewing PR #11491 to understand the initial test setup. Write tests for the three TODOs: selectionchange without changing selection, in document without browsing context, and in iframe. Investigate the noted behaviors (selectAllChildren, textarea differences) and determine expected behavior per spec. Look at existing tests in the selection directory for patterns.