wbthomason/packer.nvim

Specifying git commit doesn't work if plugin is already installed

Open

#211 opened on Feb 11, 2021

View on GitHub
 (5 comments) (1 reaction) (0 assignees)Lua (264 forks)batch import
bughelp wanted

Repository metrics

Stars
 (8,097 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Off the back of https://github.com/wbthomason/packer.nvim/issues/200#issuecomment-777848523 I just discovered and used the commit key which is a really nice feature, my initial attempt involved just adding a specific commit to an already installed plugin which resulted in an invalid commit error. Specifying the full commit not just the first characters resulted in an even more obscure git tree error. Finally deleting the plugin and re-installing it with the key specified did work.

Ideally just adding a commit to an already installed plugin as a key would be enough

PS: apologies think I'm averaging an issue a day at this rate 😓

Contributor guide

Research direction
Investigate the plugin installation logic in packer.nvim to understand why adding a commit key to an already installed plugin fails. Check the code paths for updating an existing plugin vs installing a new one, and ensure that commit specification is properly handled in both cases.
Tech stack
lua
Domain
clitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNeovimLua
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60