wbond/sublime_terminal

Terminal (OSX).sublime-settings doesn't load on MacOS 10.4 Sierra

Open

#161 opened on Feb 2, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (117 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (597 stars)
PR merge metrics
 (PR metrics pending)

Description

in get_setting: os.name returns 'posix' rather than 'darwin'.

Replacing os.name with sys.platform returns 'darwin'. This change works on MacOS and Linux. I don't have a Windows machine so can't verify the change there.

Contributor guide

Research direction
Replace os.name with sys.platform in the get setting function to correctly detect macOS.
Tech stack
python
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80