Align verify_patch Cargo checks with contributor verification commands

Open Beginner friendly
#652 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
rust, shell
Domain
build-system, developer-experience

Research direction

Start with tools/verify_patch.sh and compare its Cargo formatting, build, test, and Clippy commands with the corresponding contracts in CONTRIBUTING.md. Update the invocations and progress messages without changing patch application or cleanup behavior, then verify that each Cargo failure still fails the script and that the documented commands no longer conflict.

Written by the indexing model from the issue text.

Description

build good first issue

Current evidence

tools/verify_patch.sh currently runs bare cargo fmt --check, cargo build --quiet, cargo test --quiet, and cargo clippy -- -D warnings after applying an email patch.

CONTRIBUTING.md documents stricter Cargo verification for the repository: formatting uses cargo fmt --all --check, Clippy uses --locked --workspace --all-targets, tests use --locked --workspace --all-targets, and the normal build is locked. A patch can therefore pass the maintainer script while failing the corresponding documented Cargo gate.

Scope

  • Make the Cargo formatting, build, test, and Clippy invocations in verify_patch.sh match the corresponding current repository verification contracts.
  • Keep the script focused on its existing patch-verification stages; do not fold every Python, std-policy, corpus, or documentation check into this issue.
  • Update progress messages so they describe the commands actually being run.
  • Preserve patch application and cleanup behavior tracked separately by #638 and #639.

Completion criteria

  • Formatting covers the full workspace with the documented --all behavior.
  • Build/test/Clippy use the repository's locked/workspace/all-target contracts where applicable.
  • A failure in any updated Cargo gate still causes patch verification to fail.
  • CONTRIBUTING.md and the script no longer describe conflicting Cargo checks.
Dominant language
Rust
Stars
53
Forks
16
Avg merge
4h 6m
Merged PRs (30d)
44

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from wavefnd/Wave

All issues in wavefnd/Wave

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.