waterthetrees/wtt_server

Check queries for prepared statements

Open

#136 opened on Mar 20, 2023

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)JavaScript (4 forks)auto 404
backendenhancementgood first issue

Repository metrics

Stars
 (0 stars)
PR merge metrics
 (PR metrics pending)

Description

Use prepared statements to guard against sql injection. Good call @tzinckgraf, thanks for bringing this up! I assigned you but feel free to unassign yourself if you'd rather have someone else work on it.

TODO for this issue: check queries to make sure they are PreparedStatements

https://vitaly-t.github.io/pg-promise/PreparedStatement.html

In our code prepared statements can be formatted like this. Note, name must be unique.

const query = {
    name: 'find-source',
    text: 'SELECT * FROM sources WHERE id_source_name =  $1',
    values: idSourceName,
  };

Contributor guide

Research direction
Review all database query files in the repository to ensure they use pg promise PreparedStatement objects instead of raw query strings. Check each query follows the pattern: { name, text, values } with unique names.
Tech stack
javascriptnodejspostgresql
Domain
backendapidatabase
Issue type
Security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75