waseefakhtar/dose-android

Extract Daily, Weekly, and Monthly enum values to strings.xml

Open

#136 opened on Dec 22, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Kotlin (107 forks)auto 404
good first issuelocalization

Repository metrics

Stars
 (635 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/waseefakhtar/dose-android/blob/10b015513497b069fdaf965cbb8d250e90d0c54d/app/src/main/java/com/waseefakhtar/doseapp/feature/addmedication/AddMedicationRoute.kt#L288

https://github.com/waseefakhtar/dose-android/blob/10b015513497b069fdaf965cbb8d250e90d0c54d/app/src/main/java/com/waseefakhtar/doseapp/feature/addmedication/AddMedicationRoute.kt#L268

Also for the Recurrence Dropdown, you're using its enum name instead of providing a translated text.
I fixed this problem in one of my apps by introducing an integer variable inside the enum which refers to the resource id of the string equal to the current enum value.

Contributor guide

Research direction
Locate the Recurrence enum in AddMedicationRoute.kt, add a string resource for each enum value in strings.xml, and replace the enum name usage with the corresponding resource string.
Tech stack
kotlin
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90