Add completion spec for talosctl (Talos Linux CLI)

Open
#293 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
rust
Domain
cli, tooling

Research direction

Start in command-signatures/json/ and compare the adjacent kubectl and helm specs with oc.rs, then walk the talosctl v1.13.6 command tree. Check the hidden Cobra __complete entry point and the listed path-like flags. Done means a static spec, dynamic completion generator, and filepath/folder templates covering the stated talosctl commands and values.

Written by the indexing model from the issue text.

Description

enhancement

Link to @that70schris's main issue: https://github.com/warpdotdev/warp/issues/12693

talosctl (the Talos Linux CLI for out-of-band management of Kubernetes nodes) has no completion spec yet — command-signatures/json/ covers the adjacent kubectl and helm, but not talosctl. Warp's Oz triage on the main issue confirmed this is a native completion feature gap and marked it ready-to-implement.

Since talosctl is Cobra-based like kubectl/oc, the plan mirrors the existing precedent:

  • Static spec walked from talosctl v1.13.6's command tree (106 nodes, 49 top-level commands)
  • A talosctl_builtin_completion generator delegating dynamic completions (config contexts, node services, resource types, --nodes/--endpoints/--context values) to the CLI's hidden Cobra __complete command, same approach as oc_builtin_completion in oc.rs
  • filepaths/folders templates on path-like flags (--talosconfig, --file, --*-path, --*-dir, …)

Implementation is ready; PR to follow. @lucieleblanc could you add ready-to-implement when you get a chance (for the Oz review gate)? 🙏

Dominant language
Rust
Stars
7
Forks
10
Avg merge
8h 36m
Merged PRs (30d)
16

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/command-signatures

All issues in warpdotdev/command-signatures

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.