wagoodman/dive

Git Bash + containerized dive (Windows)

Open

#83 opened on Nov 26, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (53,932 stars) (1,995 forks)batch import
bughelp wanted

Description

Hi,

I'm trying to experiment with a containerized dive in a git bash (Windows).

I can share the /var/run/docker.sock with the container by creating this script:

#!/bin/bash

export MSYS_NO_PATHCONV=1
export COMPOSE_CONVERT_WINDOWS_PATHS=1

docker run --rm -it -v /var/run/docker.sock:/var/run/docker.sock wagoodman/dive:latest @@

However, when I execute it a get the following error:

$ dive conradoqg/cvm-fund-explorer-workers:latest
goroutine 1 [running]:
github.com/wagoodman/dive/image.check(...)
        /home/wagoodman/go/src/github.com/wagoodman/dive/image/image.go:29
github.com/wagoodman/dive/image.saveImage(0x7ffc8075af81, 0x2, 0x0, 0x0, 0x0, 0x0)
        /home/wagoodman/go/src/github.com/wagoodman/dive/image/image.go:358 +0xccc
github.com/wagoodman/dive/image.InitializeData(0x7ffc8075af81, 0x2, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/wagoodman/go/src/github.com/wagoodman/dive/image/image.go:217 +0x1cb
github.com/wagoodman/dive/cmd.analyze(0xde71a0, 0xc000261e30, 0x1, 0x1)
        /home/wagoodman/go/src/github.com/wagoodman/dive/cmd/analyze.go:36 +0x1ab
github.com/spf13/cobra.(*Command).execute(0xde71a0, 0xc00000c070, 0x1, 0x1, 0xde71a0, 0xc00000c070)
        /home/wagoodman/go/src/github.com/spf13/cobra/command.go:766 +0x2cc
github.com/spf13/cobra.(*Command).ExecuteC(0xde71a0, 0x1, 0x7fd1b1d29000, 0x0)
        /home/wagoodman/go/src/github.com/spf13/cobra/command.go:852 +0x2fd
github.com/spf13/cobra.(*Command).Execute(0xde71a0, 0xde71a0, 0xc0001adf68)
        /home/wagoodman/go/src/github.com/spf13/cobra/command.go:800 +0x2b
github.com/wagoodman/dive/cmd.Execute()
        /home/wagoodman/go/src/github.com/wagoodman/dive/cmd/root.go:30 +0x2d
main.main()
        /home/wagoodman/go/src/github.com/wagoodman/dive/main.go:38 +0xa2
  Fetching image...panic: Error response from daemon: invalid reference format

I tried other images to check if it was something related to the image itself but the message persists.

$ docker -v
Docker version 18.09.0, build 4d60db4

wagoodman/dive                                         latest              0036b48e5640        34 hours ago        65.7MB

Best

Contributor guide

Tech stack
godocker
Domain
clidevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Docker fundamentalsGit Bash on Windows basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the script at the top of the issue: the `@@` in the docker run command is likely a placeholder that was not replaced with the actual image tag. However, the error 'invalid reference format' suggests the container is receiving an empty or malformed image name. Verify how the containerized dive expects the image argument and whether it needs to be passed differently on Git Bash. Look at the command line parsing in cmd/root.go and image.go to see if there is any special handling for Windows paths. Consider testing with a minimal Docker image.