vyperlang/vyper

Handle missing "inputs" or "outputs" in abi json file

Open

#2,625 opened on Jan 27, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (4,710 stars) (849 forks)batch import
Easy Pickingshelp wanted

Description

There is an unhandled exception KerError when you are working with json interface files. Since these can sometimes be missing one of these two items, either it should raise a better error or simple skip if that key is not in the array (preferred)

Contributor guide

Tech stack
python
Domain
blockchain
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonJSON
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look into the ABI JSON parsing logic in Vyper's source code, likely in the compiler or JSON interface handling files. The issue mentions unhandled KerError when 'inputs' or 'outputs' keys are missing. A simple fix would be to skip or handle missing keys gracefully. Check for existing error handling patterns in the codebase.