vuetifyjs/vuetify

[Bug Report][3.7.0] v-text-field label color should be theme-on-background by default

Open

#20392 opened on Aug 26, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (40,995 stars) (7,139 forks)batch import
C: VLabelT: bughelp wanted

Description

Environment

Vuetify Version: 3.7.0 Vue Version: 3.4.38 Browsers: Chrome 127.0.0.0 OS: Windows 10

Steps to reproduce

Open repro

Expected Behavior

Both Label - default and Label - bg-white should be the same colour. rgba(var(--v-theme-on-background)) seems the most appropriate.

Actual Behavior

Label - default uses color from v-application, which is this: $application-color: rgba(var(--v-theme-on-background), var(--v-high-emphasis-opacity)) !default; So it adds high-emphasis-opacity to it, which is 0.87. On top of that, .v-label also has opacity: var(--v-medium-emphasis-opacity); So I think that high-emphasis-opacity is not needed in this case, and label shouldn't be using v-application color. Otherwise we'd have to add bg-white to all elements, or alter v-application color in theme which will affect regular text.

Reproduction Link

https://play.vuetifyjs.com/#...

Contributor guide

Tech stack
typescriptvuecss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Vuetify themingfamiliarity with CSS variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how Vuetify's v text field and v label components apply color, focusing on the use of 'v application' color and opacity variables. Check the source files for 'VLabel' and 'VTextField' in the vuetify repository. The goal is to change the default label color to use ' v theme on background' without the additional 'high emphasis opacity' from 'v application', as suggested in the issue. Use the provided reproduction link to verify the fix.