vuejs/vuepress

404 page does not support i18n

Open

#1987 opened on Oct 27, 2019

View on GitHub
 (6 comments) (1 reaction) (0 assignees)JavaScript (22,300 stars) (4,782 forks)batch import
complexity: easycontribution welcomeeffort: mediumgood first issuetopic: themetype: feature request

Description

  • I confirm that this is an issue rather than a question.

Bug report

I just find this on stackoverflow, and test it on the official website

Steps to reproduce

Try to visit vuepress.vuejs.org/zh/test

What is expected?

A 404 page with Chinese and

<html lang="zh-CN" >

What is actually happening?

<html lang="en-US" >

Other relevant information

  • Output of npx vuepress info in my VuePress project:

Contributor guide

Tech stack
vuejavascripthtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic VuePress projectUnderstanding of VuePress i18n
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The 404 page is rendered by the NotFound.vue component in the default theme. The issue is that the HTML lang attribute is hardcoded to 'en US' instead of using the current locale. Look at packages/@vuepress/theme default/components/NotFound.vue and the i18n helper. The fix involves dynamically setting the lang attribute based on the site's locale and ensuring translated text is displayed. Check how other components like Navbar handle locale to follow the same pattern. No linked PRs or comments indicate a solution in progress.