vuejs/vue

Wrong definition of the type AsyncComponentFactory

Open

#10,252 opened on Jul 10, 2019

View on GitHub
 (26 comments) (12 reactions) (0 assignees)TypeScript (33,833 forks)batch import
good first issuehas PRtypescript

Repository metrics

Stars
 (209,764 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Version

2.6.10

Reproduction link

https://github.com/vuejs/vue

Steps to reproduce

  1. compare the AsyncComponentFactory definition with the document

What is expected?

attribute 'component' should be a promise

What is actually happening?

AsyncComponentPromise

I'm looking forward to your solution to this issue

Contributor guide

Research direction
Compare the AsyncComponentFactory type definition in types/options.d.ts with the official Vue 2 documentation on Handling Loading State to correct the 'component' attribute type from AsyncComponentPromise to a proper promise type.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptVue
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80