vuejs/vetur

Missing props warning hightlight should not affect slots or children

Open

#2,238 opened on Sep 4, 2020

View on GitHub
 (3 comments) (2 reactions) (0 assignees)TypeScript (594 forks)github user discovery
feature-requestgood first issue

Repository metrics

Stars
 (5,752 stars)
PR merge metrics
 (PR metrics pending)

Description

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ

Info

  • Platform: macOS
  • Vetur version: 0.27.1
  • VS Code version: 1.48.2

Problem

When a component get missing props warning, it highlights all the children of the component, the file become a visual mess.

image

It should only highlight this part of the component

image

Contributor guide

Research direction
Investigate the warning highlighting logic for missing props in Vetur's template validation. Trace how the warning range is computed and why it covers the entire component instead of just the component tag.
Tech stack
typescriptvue
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptVueVS Code extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75