vuejs-templates/webpack

Warn if project path contains characters that cause problems with HMR

Open

#679 opened on Apr 19, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (4,466 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (9,721 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Not so much an issue, just a nice to have future feature change - potentially not possible, depends on how hot reloading currently happens.

Summary of the issue;

If your directory, ex. "My App" has a space hot reload doesn't work. You instead have to call it "my_app", "my-app" etc etc.

A nice MVP fix for this would be that when you run npm run dev, you get a console warning that hot reload won't work whilst there is a space in the dir name.

Contributor guide

Research direction
Examine the webpack dev server configuration or script that starts the development server. Identify where the project path is read and add a warning if it contains spaces or special characters known to break HMR.
Tech stack
javascriptvue
Domain
developer experiencebuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90