voxel51/fiftyone

[FR] Verify latitude and longitude values at creation time

Open

#2,171 opened on Oct 14, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (400 forks)batch import
coreenhancementgood first issue

Repository metrics

Stars
 (4,021 stars)
PR merge metrics
 (Avg merge 3d 11h) (161 merged PRs in 30d)

Description

Invalid lat and long coordinates in a GeoLocation field will result in the App throwing an error:

Error: Invalid LngLat latitude value: must be between -90 and 90
    at new de (http://localhost:5151/assets/index.f01320f2.js:711:66777)
    at de.convert (http://localhost:5151/assets/index.f01320f2.js:711:67409)
    at Q.extend (http://localhost:5151/assets/index.f01320f2.js:711:65535)
    at http://localhost:5151/assets/index.f01320f2.js:1790:65057
    at Array.reduce (<anonymous>)
    at bye (http://localhost:5151/assets/index.f01320f2.js:1790:65016)
    at http://localhost:5151/assets/index.f01320f2.js:1790:65695
    at Object.Gae [as useMemo] (http://localhost:5151/assets/index.f01320f2.js:34:23601)
    at Eo.useMemo (http://localhost:5151/assets/index.f01320f2.js:9:6259)
    at Tst (http://localhost:5151/assets/index.f01320f2.js:1790:65683)

It would be best to catch this error at data ingestion time.

Contributor guide

Research direction
Find where GeoLocation fields are created and add validation for latitude ( 90 to 90) and longitude ( 180 to 180) before storing.
Tech stack
python
Domain
databackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonFiftyOne
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70