voxel51/fiftyone

[FR] Default to samples tab in tag modal of expanded view

Open

#1890 opened on Jun 16, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (4,021 stars) (400 forks)batch import
appenhancementgood first issue

Description

On develop currently, opening the tag modal from the expanded view defaults to the Labels tab, but I think defaulting to the Samples tab would be more sensible (and is the default from the grid view, btw)

Contributor guide

Tech stack
reactjavascriptpython
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with React components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate the component handling the tag modal in the expanded view (likely in the fiftyone/fiftyone/desktop or fiftyone/fiftyone/teams frontend source). Look for the default tab selection logic and change it from 'Labels' to 'Samples'. The issue references a screenshot showing the current behavior.