volta-cli/volta

Investigate VS Code Git Tools & Pre-commit

Open

#516 opened on Aug 5, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (8,309 stars) (189 forks)batch import
help wantedquestion

Description

If your project has a pre-commit hook that calls a Node command, and you use VS Code Git Tools to initiate a commit, Volta appears to be finding the default Node instead of the Node specified in package.json.

A possible cause of this is VS Code is somehow executing the Git commit with a cwd that is outside of the project, causing Volta to start in the wrong directory and not find the project-local settings. If possible, we should correctly handle this case, or worst provide some guidance for how to set up VS Code to get the expected behavior.

Contributor guide

Tech stack
rustnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with RustUnderstanding of VS Code Git Tools
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate how Volta determines the current working directory when invoked by VS Code Git Tools, possibly in the launch or commit hook path. The issue suggests the cwd might be outside the project. Look at the Volta source code in the `src/` directory for functions that resolve Node versions, particularly around process environment and directory detection. Test with VS Code Git Tools to reproduce the bug. Consider adding a fallback or documentation for VS Code users.