12 comments (12 comments)2 reactions (2 reactions)0 assignees (0 assignees)Rust8,309 stars (8,309 stars)189 forks (189 forks)batch import
bughelp wanted
Description
Tool::exec doesn't propagate signals yet.
Contributor guide
- Tech stack
- rust
- Domain
- cli
- Issue type
- feature
- DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
- 3
- Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
- half day
- Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
- stale
- ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
- mostly clear
- Prerequisites
- Rust basicsProcess managementSignal handling concepts
- Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
- 45
- Research direction
- The issue is about adding signal propagation to Tool::exec. Currently, signals sent to the Volta process are not forwarded to child processes. The implementation likely involves setting up signal handlers (e.g., using `signal hook` or `tokio::signal`) and forwarding them to the child process. Review existing code in `src/` to understand how `Tool::exec` works (likely using `std::process::Command`). Also, check the 12 comments in the issue for suggested approaches or pitfalls. Look at how other Rust CLI tools handle signal propagation for reference.