voila-dashboards/voila

Add a button in the preview toolbar to open in a new browser tab

Open

#486 opened on Nov 28, 2019

View on GitHub
 (4 comments) (3 reactions) (0 assignees)Python (5,040 stars) (487 forks)batch import
good first issuejupyterlab-preview

Description

There is already a notebook:open-with-voila command to open the voila dashboard in a new browser tab. It's in the palette and the view menu, but it would be great to have it in the preview toolbar too:

image

We could for example use the jp-LauncherIcon:

image

Contributor guide

Tech stack
javascriptpython
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of JupyterLab extensions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look into the Voilà preview toolbar implementation, specifically the code that defines toolbar buttons. The command `notebook:open with voila` is already available; integrate it as a button using the `jp LauncherIcon` icon. Check the existing toolbar for patterns to add a new button. Refer to the issue comments for any additional discussion.