fix(migrate): detect Yarn PnP config even when env overrides nodeLinker
@fengmk2 is already working on this.
Since Jul 1, 2026.
Assessment
This issue has not been assessed yet.
Description
vp migrate currently treats YARN_NODE_LINKER=node-modules as enough to skip Yarn PnP handling. However, if the repository itself has .yarnrc.yml with nodeLinker: pnp, migration can complete successfully while leaving unsupported PnP config in the project. Future installs without that environment override will return to PnP mode.
Expected behavior:
- If
.yarnrc.ymlexplicitly setsnodeLinker: pnp, migration should not silently pass just becauseYARN_NODE_LINKER=node-modulesis set. - Preferably, migration should stop and ask the user to change the project config manually, or apply the existing node-modules conversion flow if that is the intended behavior.
YARN_NODE_LINKER=pnpshould still hard-block migration as today.
Suggested test:
Create a Yarn Berry fixture with:
# .yarnrc.yml
nodeLinker: pnp
Run migrate with:
YARN_NODE_LINKER=node-modules vp migrate --no-interactive
Assert that migration does not report the project as successfully migrated while leaving nodeLinker: pnp unchanged.
- Dominant language
- Rust
- Stars
- 5.8k
- Forks
- 263
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 148
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from voidzero-dev/vite-plus
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
voidzero-dev/vite-plus#2097 · 10 comments · 2 reactions ·
-
pending triage
Difficulty 5/5 Over a week Newbie friendliness 45/100
voidzero-dev/vite-plus#2781 · 2 reactions ·
-
enhancement
voidzero-dev/vite-plus#2766 · 4 comments · 1 reaction · 1 assignee ·
-
enhancement
voidzero-dev/vite-plus#2764 · 3 comments · 1 assignee ·
-
pending triage
Difficulty 3/5 1-2 days Newbie friendliness 68/100
voidzero-dev/vite-plus#2735 ·
All issues in voidzero-dev/vite-plus
Similar issues
-
Browser (wasm) relay client cannot connect to relays whose URL has a trailing-dot FQDN hostname Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
n0-computer/iroh#4550 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
paritytech/zombienet-sdk#591 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
farion1231/cc-switch#7638 · 1 comment ·
-
onnx-ir re-exports ModelProto and GraphProto but not NodeProto, AttributeProto and AttributeType Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100