vmware/pyvmomi

Python 3 string formatting bug in Iso8601.py

Open

#169 opened on Sep 17, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (2,141 stars) (807 forks)batch import
bughelp wantedlow hanging fruit

Description

There is at least one place in Iso8601.py that does not include python 3 compatible string formatting.

This indicates a poor testing coverage over date formatting issues.

  • Devise a test that exercises this section of code by only using exposed VMOMI API ... that is by sending or receiving a vSphere command.
  • After devising the test then fix the code.

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python 3vSphere API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the code at Iso8601.py line 198 to identify the Python 2-3 string formatting incompatibility. Then write a test that uses the VMOMI API to invoke date formatting, e.g., by setting or retrieving a vSphere object's date property. Finally, apply the fix using Python 3 compatible formatting like str.format() or f strings.