vmware/pyvmomi

GuiUnattended and Timezones improvement idea

Open

#162 opened on Sep 9, 2014

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (2,141 stars) (807 forks)batch import
help wantedquestionwishlist

Description

Consider:

gui_unattended = vim.vm.customization.GuiUnattended()
gui_unattended.timeZone = 35
gui_unattended.autoLogon = False

Shouldn't there be a way to set the timezones that doesn't involve using raw numbers?

Contributor guide

Tech stack
python
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonUnderstanding of pyvmomi library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, locate the GuiUnattended class definition in the pyvmomi source code, likely in the customization module (e.g., pyvmomi/vim/vm/customization.py). Examine how timeZone is currently set and used. Then, research the VMware timezone codes (integers) and propose a mapping from human readable timezone names (e.g., 'Pacific Standard Time') to these codes. This may involve adding a new method or property to accept timezone strings instead of integers. Consider consistency with other parts of the library and existing tests. Finally, open a PR with the implementation and corresponding tests.