vmware/pyvmomi-community-samples

add_nic_to_vm.py issue: TypeError: For "deviceName" expected type str, but got vim.dvs.DistributedVirtualPortgroup

Open

#647 opened on Jul 21, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (972 stars) (914 forks)batch import
help wanted

Description

Traceback (most recent call last): File "./add_nic_to_vm-new.py", line 165, in main() File "./add_nic_to_vm-new.py", line 158, in main add_nic(serviceInstance, vm, args.port_group) File "./add_nic_to_vm-new.py", line 113, in add_nic nic_spec.device.backing.deviceName = network File "/usr/local/lib/python2.7/dist-packages/pyVmomi/VmomiSupport.py", line 537, in setattr CheckField(self._GetPropertyInfo(name), val) File "/usr/local/lib/python2.7/dist-packages/pyVmomi/VmomiSupport.py", line 972, in CheckField % (info.name, info.type.name, valType.name)) TypeError: For "deviceName" expected type str, but got vim.dvs.DistributedVirtualPortgroup

If we change line #113 from: nic_spec.device.backing.deviceName = network to: nic_spec.device.backing.deviceName = network.name

then it works.

Contributor guide

Tech stack
python
Domain
cloud
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The bug is in add nic to vm.py at line 113. The traceback shows a TypeError when assigning a port group object to 'deviceName'. The fix is to change 'nic spec.device.backing.deviceName = network' to 'nic spec.device.backing.deviceName = network.name'. This is a one line change that requires no additional setup. No linked PRs or comments exist, so the issue is available for a first time contributor to patch.