vmware/pyvmomi-community-samples

Do not swallow errors!

Open

#11 opened on May 21, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (972 stars) (914 forks)batch import
enhancementhelp wanted

Description

https://github.com/vmware/pyvmomi-community-samples/blob/master/samples/create_random_marvel_vms.py#L195

In sample code, don't trap errors coming off of ...

si = connect.SmartConnect(

... instead just expose those to the CLI. We are attempting to make teaching samples here and too thoroughly swallowing or handling errors can make the samples harder to read and understand for programmers who are still learning.

Contributor guide

Tech stack
python
Domain
documentation
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Python knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Start by examining the file `samples/create random marvel vms.py` around line 195 where `connect.SmartConnect` is called. Remove the error handling that swallows exceptions, allowing them to propagate to the CLI. Check if there are other samples with similar patterns.