vizorvr/patches

Renaming a Node and clicking away should retain the rename instead of losing it

Open

#2,082 opened on Dec 13, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (40 forks)github user discovery
Enhancementgood first issuehelp wanted

Repository metrics

Stars
 (205 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Steps to replicate:

  1. Click on Node to start renaming
  2. Rename
  3. Click away

Expected result: Rename stays

Current result: Rename vanishes - user needs to press enter while renaming for renaming to stick.

Check the GIF rename node

Contributor guide

Research direction
Look at the node renaming logic, specifically the event handler for when the user clicks away (blur event). The fix likely involves saving the renaming value on blur, not only on Enter keypress.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85