vizorvr/patches

Embed in user-page does not give functioning http://vizor.io instead just says /scripts/embed.js

Open

#2,014 opened on Jul 1, 2017

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (40 forks)github user discovery
BugEnhancementgood first issuehelp wanted

Repository metrics

Stars
 (205 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

current embed code generation in profile_view ( http://vizor.io/esaruoho -> select project -> tap on Share) is missing http://vizor.io at the start

compare to what was launched way back when ( https://twitter.com/vizor_vr/status/731213475037466625 - officially posted on 13th of May 2016 on Vizor_VR) - pasted image at 2017_07_01 11_26 pm

and you'll see that really, the embed code SHOULD be created with http://vizor.io/scripts/embed.js instead of only /scripts/embed.js

the user cannot be expected to figure this out on their own. (example of confused user: https://vizorvr.slack.com/archives/C0D7S35JQ/p1498874721217943 )

Contributor guide

Research direction
Locate the embed code generation in profile view and fix the URL to include 'http://vizor.io' before '/scripts/embed.js'.
Tech stack
javascript
Domain
frontendweb dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80