vimeo/psalm

The issue message for the $<tmp coalesce var>101 is not understandable

Open

#9,807 opened on May 23, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)PHP (5,369 stars) (668 forks)batch import
Help wantedeasy problemsgood first issue

Description

https://psalm.dev/r/ec8201d718

The description of the issues is not understandable. The term $<tmp coalesce var>101 doesn't explain what's wrong exactly. The phrase $<tmp coalesce var>101 should be probably annotated differently.

ERROR: [RedundantCondition](https://psalm.dev/122) - 7:10 - Type array<array-key, mixed> for $<tmp coalesce var>101 is never null

ERROR: [TypeDoesNotContainNull](https://psalm.dev/090) - 7:33 - Cannot resolve types for $<tmp coalesce var>101 - array<array-key, mixed> does not contain null

Contributor guide

Tech stack
None
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHP basicsStatic analysis concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The error message for temporary coalesce variables is unclear. Start by examining Psalm's error message generation in the source code, likely in files related to "RedundantCondition" and "TypeDoesNotContainNull" issues. Look for how `$<tmp coalesce var>101` is produced and consider improving its readability. Check if there are any existing discussions or PRs that address similar error messages.