vimeo/psalm

The issue message for the $<tmp coalesce var>101 is not understandable

Open

#9,807 opened on May 23, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedeasy problemsgood first issue

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

https://psalm.dev/r/ec8201d718

The description of the issues is not understandable. The term $<tmp coalesce var>101 doesn't explain what's wrong exactly. The phrase $<tmp coalesce var>101 should be probably annotated differently.

ERROR: [RedundantCondition](https://psalm.dev/122) - 7:10 - Type array<array-key, mixed> for $<tmp coalesce var>101 is never null

ERROR: [TypeDoesNotContainNull](https://psalm.dev/090) - 7:33 - Cannot resolve types for $<tmp coalesce var>101 - array<array-key, mixed> does not contain null

Contributor guide

Research direction
Find the source code that generates the string `$<tmp coalesce var>` in the Psalm codebase (likely in the internal type representation) and replace it with a more descriptive message like 'temporary coalesce result'.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75