vimeo/psalm

Is it possible to disable automatic detection of simple pure methods?

Open

#9,665 opened on Apr 17, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)PHP (5,369 stars) (668 forks)batch import
Help wantedenhancementpure/immutable

Description

This is possible currently: https://psalm.dev/r/b2a9011f65

However, the library might change the following way, making it break: https://psalm.dev/r/7e645e6b69

This could be solved by making Psalm require to always explicitly define pureness as part of the method signature. At least, it would be sane to have a warning on missing pure annotations.

Contributor guide

Tech stack
None
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHPPsalm annotationsstatic analysis basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate Psalm's source code for automatic detection of pure methods, likely in the purity analysis module. Review existing configuration options for annotations and discuss with maintainers on the desired behavior. Consider adding a new config flag to require explicit pure annotations as described in the issue.