vimeo/psalm

Psalm is not complaining about false value from createFromFormat

Open

#9,223 opened on Feb 4, 2023

View on GitHubContributor guide
 (4 comments) (1 reaction) (0 assignees)PHP (668 forks)batch import
Help wantedbuginternal stubs/callmap

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (PR metrics pending)

Description

The example below should complain on both lines about calling method on false.

createFromFormat example

Contributor guide

Research direction
Inspect the return type of DateTime::createFromFormat in Psalm's stubs. Trace the code path that issues method call complaints on possibly false values and identify why false is not being propagated for this function.
Tech stack
php
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65