vimeo/psalm

Show issue for bitwise operations on floats

Open

#8,362 opened on Aug 3, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedeasy problemsenhancementgood first issue

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

I could have sworn there was a PHP warning for doing bitwise operations on floats, but apparently not... Do we want to add an issue for that to Psalm?

Originally posted by @AndrolGenhald in https://github.com/vimeo/psalm/issues/7992#issuecomment-1133272149

Apparently it is a warning, but only if the float isn't exactly an integer: https://3v4l.org/kWXWH

https://psalm.dev/r/42a6ae8735

Contributor guide

Research direction
Look at Psalm's type system for floats and existing similar warnings (e.g., for strings). Implement a new issue type `BitwiseOperationOnFloat` and detect bitwise operations on floats that are not exactly integers. Add appropriate error message and test cases.
Tech stack
php
Domain
developer experiencebackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPPsalm development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60