vimeo/psalm

Show issue for bitwise operations on floats

Open

#8,362 opened on Aug 3, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (5,369 stars) (668 forks)batch import
Help wantedeasy problemsenhancementgood first issue

Description

I could have sworn there was a PHP warning for doing bitwise operations on floats, but apparently not... Do we want to add an issue for that to Psalm?

Originally posted by @AndrolGenhald in https://github.com/vimeo/psalm/issues/7992#issuecomment-1133272149

Apparently it is a warning, but only if the float isn't exactly an integer: https://3v4l.org/kWXWH

https://psalm.dev/r/42a6ae8735

Contributor guide

Tech stack
php
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic PHP knowledgePsalm development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding a warning for bitwise operations on floats when the float is exactly an integer (since PHP only warns for non integer floats). Review the existing float related issue types in Psalm, such as `ImplicitFloatToIntConversion` or similar. Look at the linked psalm.dev example and the discussion in issue #7992. The implementation likely requires adding a new issue type in `src/Psalm/Issue/` and a check in the relevant analyzer (possibly `src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOpAnalyzer.php`). Ensure the new issue is emitted only when the float is an integer value.