vimeo/psalm

array_is_list makes the type less specific.

Open

#8,046 opened on Jun 2, 2022

View on GitHub
 (7 comments) (0 reactions) (1 assignee)PHP (668 forks)batch import
Help wantedeasy problemsenhancementgood first issue

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

https://psalm.dev/r/ffab419792

The test1 function passes the test successfully.

Errors are generated for the test2 function because array_is_list turns the $arr type into a non-empty-list<array<array-key, string>|string>.

Contributor guide

Research direction
Investigate the type narrowing logic in Psalm for array is list. Focus on how the function call affects the type of the array variable and ensure that the original type is preserved appropriately.
Tech stack
php
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65