vimeo/psalm

Possible ArgumentTypeCoercion false positive.

Open

#7,907 opened on Apr 28, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedeasy problemsenhancementtype providers

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

Hi,

It seems trimming strings breaks psalm enum type.

Please, take a look to snippet:

https://psalm.dev/r/68e999caa5 https://psalm.dev/r/41e5416030

Thank you.

Edit: fixed URLs

Contributor guide

Research direction
Investigate the 'ArgumentTypeCoercion' false positive when using string trimming on enum types in Psalm. Look at the provided psalm.dev examples and trace the type inference logic for enum cases after string operations.
Tech stack
php
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPPsalm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60