vimeo/psalm

Notice in php 8.1 autoloading causes psalm to fatal error

Open

#7,691 opened on Feb 18, 2022

View on GitHub
 (11 comments) (2 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedenhancement

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

If any autoloaded files (in libraries) fire the notice:

Return type of Class:method() should either be compatible with Class::method: OtherClass, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in FILE:LINE in /app/vendor/vimeo/psalm/src/Psalm/Internal/ErrorHandler.php:66

then psalm fails to run any analysis at all. Obviously, libraries should update their code, but psalm should still be usable.

Psalm is installed via composer at version 4.20.0

Contributor guide

Research direction
Examine the error handler at src/Psalm/Internal/ErrorHandler.php line 66 to understand how it handles notices from autoloading. Investigate PHP 8.1 return type compatibility changes and consider using the #[\ReturnTypeWillChange] attribute or suppressing the notice for autoloaded files.
Tech stack
php
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPHPComposer
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70