vimeo/psalm

The result of __toString is mistakenly assumed to be always lower-cased

Open

#7,536 opened on Jan 30, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedbugtype reconciliation

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

https://psalm.dev/r/dafc6637b5

ERROR: RedundantFunctionCall - 11:6 - The call to strtolower is unnecessary

The above error is unexpected.

Contributor guide

Research direction
Examine how Psalm infers the return type of toString and where it applies a lowercasing assumption. Trace the RedundantFunctionCall analysis to understand why it triggers for strtolower on a toString result.
Tech stack
php
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
php
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75