vimeo/psalm

Bug: psalm.xml cannot be loaded if a non-existent directory is specified

Open

#7,111 opened on Dec 9, 2021

View on GitHub
 (2 comments) (2 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedenhancement

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

I just had this strange error

Problem parsing /var/www/html/psalm.xml: Could not resolve config path to /var/www/html/

thrown from here.

The cause was this snippet in my psalm.xml:

        <RedundantConditionGivenDocblockType>
            <errorLevel type="suppress">
                <directory name="bar/"/>
            </errorLevel>
        </RedundantConditionGivenDocblockType>

I just had moved bar to foo/bar. So it could not resolve bar (realpath in Line 168 returned false). That was hard to find because the error was not very informative. Maybe we could change that so that I can see the real mistake a bit more clearly? 😅

Contributor guide

Research direction
Improve the error message in FileFilter.php when realpath returns false, so that the non existent directory name is shown.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70