vimeo/psalm

Add support for interfaces in <universalObjectCrates>

Open

#7,080 opened on Dec 6, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedenhancement

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

First of all - thank you for the wonderful tool. It helped me a lot in gradually optimizing a big codebase.

Is it possible to add an interface to ? I have an object crate, but its implementations are hidden - all I have is the interface? Right now I am checking if the returned object (which always implements the same interface) is an instance of one of the concrete classes to avoid the error.

Contributor guide

Research direction
Review the implementation of universalObjectCrates in Psalm and determine how to extend it to support interfaces. Look for existing tests and documentation.
Tech stack
php
Domain
devtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60