vimeo/psalm

Prevent comparison of null

Open

#6,869 opened on Nov 9, 2021

View on GitHub
 (6 comments) (1 reaction) (0 assignees)PHP (668 forks)batch import
Help wantedenhancement

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

With code like https://psalm.dev/r/890c56e8d0 (or a more complicated equivalent) I think it's often easy to forget to consider the case where the variable is null.

It might be useful for Psalm to emit an issue to stop comparisons with nullable values, and force the programmer to handle the null explicitly as a special case.

Contributor guide

Research direction
Investigate how Psalm currently handles null comparisons and understand the internal issue emission system. Identify the relevant code paths where comparisons with nullable values occur and add a new issue type to warn against them.
Tech stack
php
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60