vimeo/psalm

InvalidArrayOffset ignores @psalm-ignore-nullable-return

Open

#6,442 opened on Sep 6, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedbug

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

Hello, guys!

I think InvalidArrayOffset must not be fired for the case of the null array key value if the @psalm-ignore-nullable-return annotation is added to a function.

Code example https://psalm.dev/r/dffed8096a

Contributor guide

Research direction
Investigate how Psalm handles @psalm ignore nullable return in the context of array offset checks and why it fails to suppress the InvalidArrayOffset issue.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPPsalm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60