vimeo/psalm

ArgumentTypeCoercion instead of MixedArgumentTypeCoercion emitted

Open

#4,991 opened on Jan 12, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedbugeasy problemsgood first issue

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

If I understand correctly, MixedArgumentTypeCoercion is emitted when it's an iterable-specific issue, and ArgumentTypeCoercion is emitted in any other case. There are two ways to transform stdClass to an array: (array) $obj and get_object_vars($obj). In first case it will be a MixedArgumentTypeCoercion info, in the second case it will be ArgumentTypeCoercion error. https://psalm.dev/r/66737b481d

Looks like some inconsistency for me, or I can't understand some underlying logic.

Contributor guide

Research direction
Investigate the Psalm codebase to understand how ArgumentTypeCoercion and MixedArgumentTypeCoercion are issued for (array) cast vs get object vars. Trace the type analysis path for both cases and identify where the discrepancy occurs.
Tech stack
php
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70