[converter]Separate let and define

Open
#61 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Domain
compilers

Research direction

Start by tracing the converter's handling of let nodes and compare its output with the Vim script and Lisp examples in the issue. Review pull request #55 for prior context; done means declarations are emitted separately from assignments in the translated function.

Written by the indexing model from the issue text.

Description

function! s:foo()
  if v:true
    let s = 1
  else
    let s = 2
  endif
endfunction

This script is translated to

(function (s:foo)
  (if v:true
    (let = s 1)
   else
    (let = s 2)))

But this should be

(function (s:foo)
  (let = s 0) ;;; define
  (if v:true
    (let = s 1) ;;; let
   else
    (let = s 2))) ;;; let

This can be fixes with traversing let nodes, maybe.

https://github.com/vim-jp/vim-vimlparser/pull/55

Dominant language
Vim Script
Stars
173
Forks
28
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from vim-jp/vim-vimlparser

All issues in vim-jp/vim-vimlparser

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.