Patchesの表示が冗長
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start with assets/javascripts/patch-list.js and inspect how each patch title and description are assembled for the Patches list. Verify the displayed result against the issue screenshot and proposed diff, including removal of the redundant prefix and handling of HTML entities such as ", <, >, and &. Done means the right-side patch descriptions are concise and display the intended characters correctly.
Written by the indexing model from the issue text.
Description
ページの右側に表示されるPatchesの表示が冗長に思います。
この例だと、patch 8.0.0454: compiler warnings for "always true" comparison の部分は不要だと思います。また、" は " として表示されるべきでしょう。
--- a/assets/javascripts/patch-list.js
+++ b/assets/javascripts/patch-list.js
@@ -5,7 +5,7 @@ $(function() {
$.each(items, function() {
$('<li/>').append(
$('<a/>').attr({'href': this.link, 'target': '_blank'}).text("Patch " + this.title)
- ).append($('<br/>')).append($('<span/>').text(this.description)).appendTo('#patches-list');
+ ).append($('<br/>')).append($('<span/>').text(this.description.replace(/^[^\n]*\n\n/, '').replace(/"/g, '"'))).appendTo('#patches-list');
});
});
});
とりあえず、こんなパッチを当てれば表示は改善されますが、これでいいのかは分かりません。
また、" だけではなく、<, >, & なども対応が必要かもしれません。
- Dominant language
- JavaScript
- Stars
- 96
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vim-jp/vim-jp.github.io
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
vim-jp/vim-jp.github.io#415 · 1 reaction ·
-
イベント関連の記事を作成しやすくする Opencontents system
Difficulty 5/5 Over a week Newbie friendliness 25/100
vim-jp/vim-jp.github.io#237 · 1 comment ·
-
contents
Difficulty 2/5 Half a day Newbie friendliness 38/100
vim-jp/vim-jp.github.io#94 · 3 comments ·
-
contents process
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
vim-jp/vim-jp.github.io#37 · 9 comments ·
-
SEO対策しよう Opencontents
Difficulty 5/5 Over a week Newbie friendliness 25/100
vim-jp/vim-jp.github.io#25 · 11 comments ·
All issues in vim-jp/vim-jp.github.io
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·